Upgrade Struct2Tensor to TensorFlow 2.21.0#59
Open
vkarampudi wants to merge 20 commits intogoogle:masterfrom
Open
Upgrade Struct2Tensor to TensorFlow 2.21.0#59vkarampudi wants to merge 20 commits intogoogle:masterfrom
vkarampudi wants to merge 20 commits intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades
struct2tensorto support TensorFlow 2.21.0 and resolves various build system incompatibilities, dependency conflicts, and compilation errors encountered during the process.Key Changes
1. TensorFlow 2.21.0 Dependency Resolution Conflicts
.bazelversionto7.7.0to align with TensorFlow 2.21.0 requirements.rules_java,local_config_cuda,local_config_tensorrt,llvm-raw, etc.).struct2tensor.2. Python 3.12 Support and Python 3.9 Drop
pyarrow(>=14),h5py, andml-dtypes.3. Protobuf Version Mismatch (Compiler vs. Headers)
protocthan the Protocol Buffer headers being included in compilation.common --noenable_bzlmodand moved theregister_toolchainscall to the very top of the WORKSPACE file to enforce correct resolution priority. We also applied a specialized patch (protobuf_tensorflow.patch) to fix macro and namespace issues.4. GCC 15 Linker Relocation Errors
--copt=-Wa,--gsframe=noflag under the Linux configuration in .bazelrc to disable SFrame generation.5. Test Sharding Validation Errors
test --noincompatible_check_sharding_supportto .bazelrc to allow the tests to skip this check and execute successfully.6. CI Pre-Commit Hook Failures
pre-commitworkflow in GitHub Actions failed due to linting and small formatting issues.Verification
All tests passed successfully locally:
bazel test //... --noincompatible_check_sharding_support ...